This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-5/dart): review edits and code cleanup#1643
Merged
kwalrath merged 2 commits intoangular:masterfrom Jun 15, 2016
Merged
docs(toh-5/dart): review edits and code cleanup#1643kwalrath merged 2 commits intoangular:masterfrom
kwalrath merged 2 commits intoangular:masterfrom
Conversation
Contributor
Author
chalin
force-pushed
the
chalin-toh-5-dart-minor-edits-0609
branch
from
9061fda to
c50d805
Compare
Foxandxss
added
pr_state: WIP
action: review
type: copy edits
dart
and removed
pr_state: WIP
labels
chalin
force-pushed
the
chalin-toh-5-dart-minor-edits-0609
branch
2 times, most recently
from
8dde8eb to
ebb6ad7
Compare
chalin
force-pushed
the
chalin-toh-5-dart-minor-edits-0609
branch
from
ebb6ad7 to
8203d4e
Compare
| * add routing | ||
| * create a new `DashboardComponent` | ||
| * tie the *Dashboard* into the navigation structure. | ||
| * turn `AppComponent` into an application shell that only handles navigation, |
Contributor
There was a problem hiding this comment.
If we're editing this, I'd use sentence caps but not add commas at the end. (Periods would be fine, though.) I'd also add a colon after "plan". For example:
Here's our plan:
- Turn ... navigation.
- ...
- Tie ... structure.
Contributor
Author
There was a problem hiding this comment.
That is my preference too. Done.
Contributor
|
The changes look good, with the exception of what I commented on. (This page needs a good copy edit, but I tried to avoid looking at anything you didn't change!) |
Contributor
Author
|
I agree about further copy edits. For now, I have addressed the points that you raised, and made the changes to both the TS and Dart sides so that they match. |
Contributor
|
LGTM. Merging now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code:
Contributing to #1628.